Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getidx for GradientC2F with SetValue bcs #2148

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix getidx for GradientC2F with SetValue bcs #2148

merged 1 commit into from
Jan 22, 2025

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Jan 21, 2025 •
edited
Loading

Closes #994. cc @kmdeck.

In a followup, we can fix #2089, which would have caught this error.

dennisYatunin
dennisYatunin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@dennisYatunin dennisYatunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idx -> hidx change looks correct, but the other change seems unnecessary.

@charleskawczynski charleskawczynski merged commit 2c9869d into main Jan 22, 2025
32 of 33 checks passed
@charleskawczynski charleskawczynski deleted the ck/fix_994 branch January 22, 2025 13:24
@charleskawczynski charleskawczynski mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisYatunin dennisYatunin dennisYatunin approved these changes

@Sbozzolo Sbozzolo Awaiting requested review from Sbozzolo

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add finite difference operator unit tests Spatially varying BC dont work for grads?
2 participants
@charleskawczynski @dennisYatunin