One degree simulation in the examples and correct documentation #276
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 1983 1998 +15
=====================================
- Misses 1983 1998 +15 ☔ View full report in Codecov by Sentry. |
|
I think it would be nice as the objective of this PR to have a working one degree simulation in the examples (probably it will take a while) |
simone-silvestri
changed the title
…into ss/one-degree-take3
|
Should we include it in the literated examples? |
I think that would be very nice. There are probably a lot of users that want to run a coarser version of the global simulation. I think the roadmap to get this simulation working as an example is as follows:
We could start including the simulation in the examples with the current GM which should work in terms of results, but it is very slow (see issue #3938 in Oceananigans) Then, once we have sea ice coupled we should update the example |
…into ss/one-degree-take3
|
Ready to merge I think |
| Tn = @lift begin | ||
| Tn = interior(T[$n]) | ||
| Tn[land] .= NaN | ||
| view(Tn, :, :, 1) | ||
| end |
There was a problem hiding this comment.
doesn't the plotting extension do this?
There was a problem hiding this comment.
not for a tripolar grid
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
Co-authored-by: Gregory L. Wagner <[email protected]>
simone-silvestri
changed the title
src/OceanSimulations.jl
Outdated
| # - 30 minutes for a 1 degree ocean | ||
| # - 15 minutes for a 1/4 degree ocean | ||
| # - 7.5 minutes for a 1/8 degree ocean | ||
| # - 3.75 minutes for a 1/16 degree ocean | ||
| # - 1.875 minutes for a 1/32 degree ocean | ||
|
|
||
| return 40minutes / Δθ | ||
| return 30minutes / Δθ |
There was a problem hiding this comment.
aha. I thought it was 20 minutes in fact (do to Coriolis, but wasn't sure if you discovered something...)
A couple of bugs have been fixed. Now the one degree is stable. To be correct we need to implement a PolarBoundaryCondition for JRA55 fields and the input bathymetry since they span (-90, 90) on a latitude-longitude grid.
Also fixes a small bug where
Timewas not imported inPrescribedAtmospheresand brings the syntax of the other examples up to speed os that the docs run.