Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix set!ting ECCO FTS with cycling boundaries #290

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

simone-silvestri
Copy link
Collaborator

which should happen as soon as model.clock.time > last(ECCO_times(metadata))

@simone-silvestri simone-silvestri changed the title Add a test for ECCORestoring cycling Bugfix set!ting ECCO FTS with cycling boundaries Dec 10, 2024
@glwagner
Copy link
Member

glwagner commented Dec 10, 2024

don't you wnt to add this to the PR with the test? This is test driven dev: open a PR with the test, then commit to the fix, then merge. Boom done.

Sorry got confused cause the title change. You did it!

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6d3d822) to head (c2faa11).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO_restoring.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #290   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1921    1926    +5     
=====================================
- Misses      1921    1926    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri simone-silvestri merged commit 3db2d25 into main Dec 11, 2024
20 checks passed
@simone-silvestri simone-silvestri deleted the ss/test-ecco-cycling branch December 11, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants