Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke neverworld_simulation.jl #53

Closed
glwagner opened this issue Oct 31, 2023 · 2 comments · Fixed by #54
Closed

Nuke neverworld_simulation.jl #53

glwagner opened this issue Oct 31, 2023 · 2 comments · Fixed by #54

Comments

@glwagner
Copy link
Member

@sandreza @simone-silvestri

Unfortunately nobody started using neverworld_simulation in ClimaOcean.jl. Since it takes work to maintain, I'm going to nuke it. Raising this issue in case you have changed your mind and would like to conduct your neverworld work here after all.

Here's the code: https://github.com/CliMA/ClimaOcean.jl/blob/main/src/IdealizedSimulations/neverworld_simulation.jl

@simone-silvestri
Copy link
Collaborator

I am not sure, it sounds bad to nuke the whole code. I think it might become of interest to people in the future. But if it's a burden to maintain especially now that ClimaOcean is "starting" and will probably go through many refactors, it is probably best to nuke it.

@glwagner
Copy link
Member Author

glwagner commented Nov 1, 2023

Yes, if there were no other trade-off we wouldn't need to delete it. It will be in git history for anyone who would like to update the old code to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants