Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, compat entries and use Julia v1.9 #44

Merged
merged 10 commits into from
Oct 14, 2023

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Sep 20, 2023

No description provided.

@navidcy navidcy requested a review from glwagner September 20, 2023 09:35
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8e6fedd) 7.81% compared to head (660e025) 7.81%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #44   +/-   ##
=====================================
  Coverage   7.81%   7.81%           
=====================================
  Files         12      12           
  Lines        678     678           
=====================================
  Hits          53      53           
  Misses       625     625           
Files Coverage Δ
src/ClimaOcean.jl 73.33% <ø> (ø)
src/DataWrangling.jl 0.00% <ø> (ø)
src/VerticalGrids.jl 81.81% <ø> (ø)
src/Diagnostics.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navidcy navidcy changed the title Update compat entries for deps Update deps, compat entries and use Julia v1.9 Sep 20, 2023
@glwagner
Copy link
Member

@navidcy
Copy link
Collaborator Author

navidcy commented Oct 13, 2023

@navidcy what documenter version do we need?

https://github.com/CliMA/ClimaOcean.jl/actions/runs/6499139777/job/17651884235?pr=44#step:6:10

Documenter v1 has breaking changes; I tried to enforce using Documenter v1 + fix what was needed in the makedocs

@navidcy
Copy link
Collaborator Author

navidcy commented Oct 14, 2023

@glwagner, can you have a look?

@glwagner glwagner merged commit f69f130 into main Oct 14, 2023
7 of 8 checks passed
@glwagner glwagner deleted the ncc/update-compat-entries branch October 14, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants