Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of ARS343 #56

Open
2 of 8 tasks
charleskawczynski opened this issue Sep 13, 2022 · 0 comments
Open
2 of 8 tasks

Performance of ARS343 #56

charleskawczynski opened this issue Sep 13, 2022 · 0 comments

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Sep 13, 2022

Verify number of iterations

  • 3 num implicit stages
    • Wfact! (should be called 1 time, called 3 for now)
    • linsolve! 3 * num newton iterations
    • implicit_tendency_generic! 3 * num newton iterations
  • 4 num explicit stages
    • remaining_tendency_increment! 4
  • 3 expected convergence order

Reduce number of Newton iterations

  • It may be that we only need a single newton iteration, like Rosenbrock23

Reduce number of Wfact! calls

  • Jacobian (reduce number of Wfact!s)

Inference

  • remove @generated?

ForwardEulerFunction

I wrote this when chatting with @dennisYatunin but I forget the context here, was this performance related? Or feature related? (or both?)

  • give ForwardEulerFunction jac_prototype, so we can use ForwardEulerFunction for implicit, so that we can apply filter on implicit tendency.
@charleskawczynski charleskawczynski changed the title Verify number of evaluations in ARS343 Performance of ARS343 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant