Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to set FieldTimeSeries to a function #3932

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add capability to set FieldTimeSeries to a function #3932

wants to merge 4 commits into from

Conversation

glwagner
Copy link
Member

Resolves #3929

navidcy
navidcy approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a test a good idea?

@navidcy
Copy link
Collaborator

navidcy commented Nov 17, 2024

This fails with a FieldTimeSeries-related error:

https://buildkite.com/clima/oceananigans/builds/19110#019331ff-c6f7-45d2-a670-eacf8bc3d20d/16-1236

@glwagner
Copy link
Member Author

Yes for sure I'd like to add some simple tests

@glwagner
Copy link
Member Author

https://buildkite.com/clima/oceananigans/builds/19110#019331ff-c6f7-45d2-a670-eacf8bc3d20d/16-1236

true, method ambiguity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidcy navidcy navidcy approved these changes

Assignees
No one assigned
Labels
user interface/experience 💻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for using set! on FieldTimeSeries with functions of time
2 participants
@glwagner @navidcy