Add downstream tests for ClimaAtmos.jl
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriharshakandala
force-pushed
the
sk/add_downstream_tests
branch
2 times, most recently
from
8040162 to
da2090b
Compare
Sbozzolo
reviewed
Oct 1, 2024
|
Thank you! The ClimaCoupler test is failing because RRTMGP is not a direct dependency of ClimaCoupler, so Aqua fails. The ClimaCoupler testsuite is also not indicative of AMIP and does not call anything related to RRTMGP (but we are working on this) I'd say that we can start by merging the test for atmos, and add the test for Coupler/AMIP as soon as we add the test there. |
sriharshakandala
force-pushed
the
sk/add_downstream_tests
branch
from
c5d1e85 to
cd0879e
Compare
sriharshakandala
changed the title
ClimaAtmos.jl and ClimaCoupler.jlClimaAtmos.jl
Sbozzolo
approved these changes
Oct 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add downstream tests for
ClimaAtmos.jl.