better place for these tests knobs to live

Author: dpsutton

src/metabase/driver/clickhouse.clj

@@ -50,12 +50,7 @@
                               :left-join                       (not config/is-test?)
                               :describe-fks                    false
                               :actions                         false
-                              :metadata/key-constraints        (not config/is-test?)
-
-                              :metabase.driver.sql-jdbc.sync.describe-table-test/describe-view-fields
-                              true
-                              :metabase.driver.sql-jdbc.sync.describe-table-test/describe-materialized-view-fields
-                              false}]
+                              :metadata/key-constraints        (not config/is-test?)}]
   (defmethod driver/database-supports? [:clickhouse feature] [_driver _feature _db] supported?))
 
 (def ^:private default-connection-details

test/metabase/test/data/clickhouse.clj

@@ -6,6 +6,7 @@
    [clojure.string :as str]
    [clojure.test :refer :all]
    [metabase.db.query :as mdb.query]
+   [metabase.driver :as driver]
    [metabase.driver.ddl.interface :as ddl.i]
    [metabase.driver.sql-jdbc.connection :as sql-jdbc.conn]
    [metabase.driver.sql-jdbc.execute :as sql-jdbc.execute]
@@ -25,6 +26,11 @@
 
 (sql-jdbc.tx/add-test-extensions! :clickhouse)
 
+(defmethod driver/database-supports? [:clickhouse :metabase.driver.sql-jdbc.sync.describe-table-test/describe-view-fields]
+  [_driver _feature _db] true)
+(defmethod driver/database-supports? [:clickhouse :metabase.driver.sql-jdbc.sync.describe-table-test/describe-materialized-view-fields]
+  [_driver _feature _db] false)
+
 (def default-connection-params
   {:classname "com.clickhouse.jdbc.ClickHouseDriver"
    :subprotocol "clickhouse"