Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rows and Columns Editor missing & Rows no longer applied #1277

Open
StaleLoafOfBread opened this issue Feb 21, 2025 · 4 comments
Open

Rows and Columns Editor missing & Rows no longer applied #1277

StaleLoafOfBread opened this issue Feb 21, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@StaleLoafOfBread
Copy link

Describe the bug
Rows and Columns Editor missing & Rows no longer applied

To Reproduce

  1. Create card via yaml below.
  2. Observe gui lacks old drop down
  3. Observe that card is repecting the column but not the row

If this feature is purposely deprecated, then the version should probably be v3 as this would be a breaking change.

Expected behavior
The card to be 25% as high when row set to 0.25 and twice as high when set to 2.
The old gui to still be present (see screenshots).

Screenshots
v2.5.0-beta.7:
Image

v2.4.0:
Image

YAML

type: custom:bubble-card
card_type: separator
modules:
  - default
name: Example
rows: 0.25
columns: 2

Informations (please complete the following information):

  • OS: Windows 11
  • Browser/App: [Chrome
  • Bubble Card version: v2.5.0-beta.7
  • Home Assistant version: v2025.2.4
@StaleLoafOfBread StaleLoafOfBread added the bug Something isn't working label Feb 21, 2025
@MrBearPresident
Copy link
Collaborator

@Clooos

Commit Editor from L230-L251

@Clooos
Copy link
Owner

Clooos commented Feb 21, 2025 •
edited
Loading

Hi! This is intended, I've removed it because this is not needed anymore, the migration of previous columns/rows values should be automatic, you can now use the default "Layout" tab in the editor for that.

@Clooos
Copy link
Owner

Clooos commented Feb 21, 2025

Indeed rows are not migrated, I will add that for the next release.

@Clooos Clooos reopened this Feb 21, 2025
@StaleLoafOfBread
Copy link
Author

Thank you for the clarification and adding row migration to your list of things to add to the next release!

Clooos added a commit that referenced this issue Mar 1, 2025
@Clooos
New card structure + Large is default (WIP) + More
9177be1 
- [ ] Added « Tap action on card » for the cover card (editor missing).
- [ ] Added « Tap action on card » for the climate card (editor missing).
- [ ] Separator centered based on row height or default height if no row?
- [ ] Bug pop-up that randomly change to cropped in editor
- [ ] Revert custom styles name in editor
- [ ] Finish migration to large layout (need more thinking)
- [x] Changed the default color for the line in the separator card, for more contrast on some backgrounds
- [x] Icon color change beta 2.5.0-beta.6 #1266
- [x] Added the missing curtain icons
- [x] Added « Tap action on card » for the media player card.
- [x] Attempt to fix « Card flashing bug in 2.5.0 beta »#1276
- [x] Added missing previous rows value conversion #1277
- [x] Added support for `!include` in the `bubble-modules.yaml` #1262

   default:
     !include default.yaml

   This will import the config from `/local/bubble/default.yaml to match the Home Assistant YAML possibilities.
@Clooos Clooos mentioned this issue Mar 1, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Clooos @StaleLoafOfBread @MrBearPresident