Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails silently if <assemblyBinding> has unexpected XML elements #7

Open
plutora-steve-g opened this issue Sep 13, 2021 · 0 comments
Open

Comments

@plutora-steve-g
Copy link

plutora-steve-g commented Sep 13, 2021

Installed product versions

  • Visual Studio: 2019 16.11.1
  • This extension: 1.1.1

Description

Don't lose sleep over this one.

We had an assemblyBinding section with an invalid child element. When we ran BRDr over this file it failed silently.

Steps to recreate

  1. Open a web/app.config file with an assemblyBinding section with valid children.
  2. Add a <probing privatePath="lib;libs" /> element as a child of <assemblyBinding> - I haven't tested as the first element.
  3. Save file

Current behavior

DATE TIME: Backup created for FILENAME

Expected behavior

DATE TIME: Backup created for FILENAME
DATE TIME: Backup created for FILENAME
DATE TIME: Update complete. Result: BEFORECOUNT bindings before, AFTERCOUNT after.

Other comments

This is a great extension and should be default Visual Studio behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant