Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4: plotting_helper_functions.extract_relevant_dataframes() saves the data frame #4

Open
jyotikab opened this issue Feb 22, 2023 · 2 comments
Open

Issue #4: plotting_helper_functions.extract_relevant_dataframes() saves the data frame #4

jyotikab opened this issue Feb 22, 2023 · 2 comments
Assignees
@jyotikab
Labels
bug Something isn't working

Comments

@jyotikab
Copy link
Collaborator

The function should not covertly save the dataframe along with returning it. Dont save it. This function also does the (helpful) overwrite of the column names of results[0]['popfreqs'] with sensible nuclei names.
@jyotikab jyotikab added the bug Something isn't working label Feb 22, 2023
@jyotikab jyotikab self-assigned this Feb 22, 2023
@jyotikab
Copy link
Collaborator Author

extract_relevant_dataframes() no longer saves anything.

@giossic
Copy link
Collaborator

giossic commented Mar 1, 2023

True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyotikab jyotikab

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyotikab @giossic