Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change units for delta parameter? #23

Open
jrasero opened this issue Feb 15, 2022 · 0 comments
Open

Change units for delta parameter? #23

jrasero opened this issue Feb 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jrasero
Copy link
Member

jrasero commented Feb 15, 2022

Delta hyperparameter, which defines the minimum distance for a peak to be considered as such, is given in sampling units.

For example, we usually take delta = 200, because for a recording of 400 Hz sampling frequency corresponds to a peak every 0.5 sec at least, i.e., the maximum peaks per minute that we can have with this choice is 120.

Maybe we could express this parameter in terms of peaks per second? This seems more understandable than in sampling units. For example, delta = 200 would correspond to 0.5. Since we are always passing the sampling frequency, we can convert from one to the other and viceversa.

@jrasero jrasero added the enhancement New feature or request label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant