From 3900bc17af084a88b0e01fc585be653f1325681f Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Thu, 20 Nov 2014 10:10:38 -0600 Subject: [PATCH 1/4] fixes static analyzer issues. --- Core/Source/iOS/DTProgressHUD/DTProgressHUD.m | 1 - Core/Source/iOS/DTSidePanel/DTSidePanelController.m | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Core/Source/iOS/DTProgressHUD/DTProgressHUD.m b/Core/Source/iOS/DTProgressHUD/DTProgressHUD.m index 5ffe67d7..6d5017b2 100644 --- a/Core/Source/iOS/DTProgressHUD/DTProgressHUD.m +++ b/Core/Source/iOS/DTProgressHUD/DTProgressHUD.m @@ -276,7 +276,6 @@ - (void)_showAnimation [collision addBoundaryWithIdentifier:@"barrier1" fromPoint:leftPoint toPoint:rightPoint]; // calculate points for barrier - height = self.center.y + PROGRESS_HEIGHT / 2; leftPoint = CGPointMake(0, 0); rightPoint = CGPointMake(self.center.x - PROGRESS_WIDTH / 2 - offset + BARRIER_LENGTH, 0); [collision addBoundaryWithIdentifier:@"barrier2" fromPoint:leftPoint toPoint:rightPoint]; diff --git a/Core/Source/iOS/DTSidePanel/DTSidePanelController.m b/Core/Source/iOS/DTSidePanel/DTSidePanelController.m index c6ff9ebd..cd19e96b 100644 --- a/Core/Source/iOS/DTSidePanel/DTSidePanelController.m +++ b/Core/Source/iOS/DTSidePanel/DTSidePanelController.m @@ -737,7 +737,7 @@ - (void)handlePan:(UIPanGestureRecognizer *)gesture - (void)presentPanel:(DTSidePanelControllerPanel)panel animated:(BOOL)animated { - CGPoint targetPosition; + CGPoint targetPosition = [self _centerPanelPositionWithLeftPanelOpen]; _panelToPresentAfterLayout = panel; From e5ccb4aa68c99ba6240a4452dfd6b5615042de81 Mon Sep 17 00:00:00 2001 From: Oliver Drobnik Date: Tue, 2 Dec 2014 19:46:06 +0100 Subject: [PATCH 2/4] Fixed analyze warning --- Core/Source/DTZipArchive/DTZipArchiveGZip.m | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Core/Source/DTZipArchive/DTZipArchiveGZip.m b/Core/Source/DTZipArchive/DTZipArchiveGZip.m index 71115bac..85dec983 100644 --- a/Core/Source/DTZipArchive/DTZipArchiveGZip.m +++ b/Core/Source/DTZipArchive/DTZipArchiveGZip.m @@ -244,8 +244,11 @@ - (NSData *)uncompressZipArchiveNode:(DTZipArchiveNode *)node withError:(NSError { if (![self.nodes containsObject:node]) { - NSDictionary *userInfo = @{NSLocalizedDescriptionKey : @"Invalid node specified, cannot uncompress GZip file."}; - *error = [[NSError alloc] initWithDomain:DTZipArchiveErrorDomain code:7 userInfo:userInfo]; + if (error) + { + NSDictionary *userInfo = @{NSLocalizedDescriptionKey : @"Invalid node specified, cannot uncompress GZip file."}; + *error = [[NSError alloc] initWithDomain:DTZipArchiveErrorDomain code:7 userInfo:userInfo]; + } return nil; } From 686419956878e1c1ee7e6ff20ade6f06320797cd Mon Sep 17 00:00:00 2001 From: Oliver Drobnik Date: Tue, 2 Dec 2014 20:09:31 +0100 Subject: [PATCH 3/4] Reindented --- Core/Source/iOS/DTSidePanel/DTSidePanelController.m | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Core/Source/iOS/DTSidePanel/DTSidePanelController.m b/Core/Source/iOS/DTSidePanel/DTSidePanelController.m index cd19e96b..53f40ca4 100644 --- a/Core/Source/iOS/DTSidePanel/DTSidePanelController.m +++ b/Core/Source/iOS/DTSidePanel/DTSidePanelController.m @@ -777,10 +777,10 @@ - (void)presentPanel:(DTSidePanelControllerPanel)panel animated:(BOOL)animated break; } - case DTSidePanelControllerPanelNone: - { - break; - } + case DTSidePanelControllerPanelNone: + { + break; + } } if (animated) From 6b2794ad9af705c403fecb7fbfacdc5e09186d17 Mon Sep 17 00:00:00 2001 From: Oliver Drobnik Date: Tue, 2 Dec 2014 20:11:49 +0100 Subject: [PATCH 4/4] Updated change log --- Documentation/Change Log-template.markdown | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/Change Log-template.markdown b/Documentation/Change Log-template.markdown index d82a8fbf..915c2d48 100644 --- a/Documentation/Change Log-template.markdown +++ b/Documentation/Change Log-template.markdown @@ -7,6 +7,8 @@ This is the history of version updates. - FIXED: Added armv7s to static library targets (iOS) - FIXED: [DTZipArchive] unit test would sometimes fail +- FIXED: Analyzer warnings +- FIXED: Log message of main thread checker would mention incorrect symbol for debugging - ADDED: CocoaPods specs for DTScripting, Debug and Runtime - ADDED: Dynamic framework for iOS8 - REMOVED: Deprecated static framework for iOS