Play sound for notifications when they execute. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Play different sounds which built in OSX for each status: 1. Failed (Sound is Sosumi) 2. Notify (Sound is Blow) 3. Pending (Sound is Morse) 4. Success (Sound is Hero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the new feature which play sound for notifications,
in order to make easier for user to notice them.
Play different sounds which built in OSX for each status:
These 4 mappings from status to sounds are hard coded in the constant OSX_BUILT_IN_SOUNDS.
If you want to fix it (e.g. create file for sound configuration), I'll do it