You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just noticed another leak, but this one is event handler leak when we have lots of RPC calls cancelled. You can try run CallerDealerTests.LeakTestOnCancelCalls from this demo branch
The issue is that every time WampCalleeInvocationHandler.Cancel is called, it creates a temporary WampRpcOperationCallback to get a potential existing WampRpcInvocation. However in WampRpcOperationCallbackconstructor it connects mMonitor.ConnectionClosed and this event handler is never removed. I'm thinking it probably should not connect in constructor or we will need a different type for the key in the mCallbackToInvocation dictionary that only takes in Session and RequestId from WampRpcOperationCallback.
The text was updated successfully, but these errors were encountered:
Hi @darkl,
Just noticed another leak, but this one is event handler leak when we have lots of RPC calls cancelled. You can try run
CallerDealerTests.LeakTestOnCancelCalls
from this demo branchThe issue is that every time
WampCalleeInvocationHandler.Cancel
is called, it creates a temporaryWampRpcOperationCallback
to get a potential existingWampRpcInvocation
. However inWampRpcOperationCallback
constructor it connectsmMonitor.ConnectionClosed
and this event handler is never removed. I'm thinking it probably should not connect in constructor or we will need a different type for the key in themCallbackToInvocation
dictionary that only takes inSession
andRequestId
fromWampRpcOperationCallback
.The text was updated successfully, but these errors were encountered: