Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option experimentalTabCompleteFixForTabSize80 doesn't work #719

Open
andreasdc opened this issue Apr 19, 2023 · 15 comments
Open

Option experimentalTabCompleteFixForTabSize80 doesn't work #719

andreasdc opened this issue Apr 19, 2023 · 15 comments
Labels

Comments

@andreasdc
Copy link

The experimentalTabCompleteFixForTabSize80 option doesn't work I guess?
image

@Andre601
Copy link
Contributor

Do you actually use a fixed size tab list with size 80?

@andreasdc
Copy link
Author

type: FIXED_SIZE
size: 80

@CodeCrafter47
Copy link
Owner

The option only works for clients on version 1.19.2 or older.

@andreasdc
Copy link
Author

andreasdc commented Apr 19, 2023

Is workaround possible?

@andreasdc
Copy link
Author

Maybe something like custom, secret or near empty names?

@andreasdc
Copy link
Author

bump

@Andre601
Copy link
Contributor

Bumping won't make it be solved any faster. Be patient

@CodeCrafter47
Copy link
Owner

The experimentalTabCompleteFixForTabSize80 option no longer works for the latest Minecraft versions. This is due to changes on the client and there is nothing I can do to fix it.

The experimentalTabCompleteSmileys option should still work, though.

@andreasdc
Copy link
Author

What did change exactly?

@Andre601
Copy link
Contributor

This is me guessing but since 1.19.3 are players no longer required to be in the tab list to have their skin displayed in the server, so this is probably the cause, as the Client no longer needs to get the Player tab info for seeing the other players on the server. So maybe some relevant code that made the experimental option work has been removed or changed.

@andreasdc
Copy link
Author

Isn't it better to keep the fix?

@CodeCrafter47
Copy link
Owner

The previous fix relied on the minecraft client using a specific datastructure to store the tab list entries. We used the empty string as name (which doesn't show up in tab completion) and tweaked the entries, such that the hash function would ensure the correct order.
I don't remember the details, but I looked at it when the 1.19.3 update has been published, and a similar fix is no longer possible.

@andreasdc
Copy link
Author

I don't understand this, can you take a look into it by any chance?

@Andre601
Copy link
Contributor

He just told you that he can't fix it...

@andreasdc
Copy link
Author

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants