Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the MoreSFSymbols dependency #10

Open
Angelk90 opened this issue Jun 12, 2022 · 6 comments
Open

Add the MoreSFSymbols dependency #10

Angelk90 opened this issue Jun 12, 2022 · 6 comments

Comments

@Angelk90
Copy link

Hi @lukepistrol , it would be possible to add the following dependency MoreSFSymbols.

To use the Developer icons:

Schermata 2022-06-12 alle 10 32 05

@lukepistrol
Copy link
Member

I like the icons but unfortunately they don't work well in all weights

@Angelk90
Copy link
Author

@austincondiff : Do you think you can solve this problem?

@austincondiff
Copy link
Contributor

Yes, we can make them look good in all weights. (sorry just now seeing this)

@lukepistrol
Copy link
Member

@austincondiff have you successfully done that?

@austincondiff
Copy link
Contributor

I have manually pulled some of their assets into our project locally (haven't pushed anything at the time of this comment). Should I instead be bringing it in as a dependency and forwarding these symbols?

@lukepistrol
Copy link
Member

The thing is, that some of the symbols look odd in specific weights.

e.g.:
Screenshot 2023-01-25 at 00 40 25

We would need to make sure they look good in all weights or just go for only one weight.

Adding it as a dependency won't work since it is not a swift package. just a collection of symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants