s3Client settings validation

[spawn-guy]

Hello,
I've planned to use the "default" approach with configuring AWS
http://docs.aws.amazon.com/aws-sdk-php/guide/latest/quick-start.html#client-factory-method
they, basically, say that most of the options are "optional" or "replaceable".

but in \Codesleeve\Stapler\Validator->validateS3Options there are those checks.. that stop me from using key=null,secret=null. and, actually, they are not that much needed, if these keys are read from the environment. and if i already have a default AWS Instance.
i was thinking about using 's3_client_config' => null, to use the default config.

i think S3Client will throw an error if it was mis-configured. but stapler adds an additional level of validation.. so i must say: "These options will be NOT passed directly" but "validated and passed".

Is it possible to remove those validators?
or update them to the proper AWS implemented version?
any other ideas?

[tabennett]

Yeah, think we can remove those validation checks. When I first wrote the S3 driver I had no idea you could even store your instance profile credentials like that (via AWS IAM). I'll see if about getting those removed. If you want to PR it you're more than welcome to.

[almunnings]

Also noting that the key and secret have moved into a credentials array for 3.0.x of SDK.
This is an annoyance now.

Workaround is to just leave the key and secret array keys as junk in the settings.

    's3_client_config' => [
        'region' => env('AWS_REGION', ''),
        'scheme' => 'https',
        'version' => 'latest',
        'timeout' => 30,
        'credentials' => array(
            'key' => env('AWS_KEY', ''),
            'secret' => env('AWS_SECRET', ''),
        ),
        // Legacy stapler support
        'key' => 'legacy',
        'secret' => 'legacy',
    ],