AWS S3 ACL and Scheme settings?

[timReynolds]

Is anyone using the AWS S3 adaptor with ACL set to anything other than the default? When trying to use it with something like authenticated-read I don't get a signed response back. This seems to be down to the fact the following code doesn't specify an expiry;

    /**
     * Return the url for a file upload.
     *
     * @param  string $styleName
     * @return string
     */
    public function url($styleName)
    {
        return $this->s3Client->getObjectUrl($this->attachedFile->s3_object_config['Bucket'], $this->path($styleName));
    }

Which based on my reading of the AWS docs is needed to get a pre-signed url which I believe is needed for anything other than public read.

Has anyone else had this issue? More than happy to make the required changes but wasn't convinced I correctly understood the code base.

[timReynolds]

For reference the S3 client method logic is;

    public function getObjectUrl($bucket, $key, $expires = null, array $args = array())
    {
        $command = $this->getCommand('GetObject', $args + array('Bucket' => $bucket, 'Key' => $key));
        if ($command->hasKey('Scheme')) {
            $scheme = $command['Scheme'];
            $request = $command->remove('Scheme')->prepare()->setScheme($scheme)->setPort(null);
        } else {
            $request = $command->prepare();
        }
        return $expires ? $this->createPresignedUrl($request, $expires) : $request->getUrl();
    }

[flaxandteal]

Apologies for re-awakening an old issue, but rather than starting a new one when this is still open - I have a fork with expiring-url functionality. I am happy to prepare a pull request if it would be helpful?

[Dylan-Buth]

@flaxandteal Did you ever create that pull request? Maybe I'm missing it but I can't find a way to display the private PDF on s3 to the user.