Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all annotations in store instead of only the ones requested. #209

Open
daanvdk opened this issue Feb 17, 2022 · 0 comments
Open

Ignore all annotations in store instead of only the ones requested. #209

daanvdk opened this issue Feb 17, 2022 · 0 comments

Comments

@daanvdk
Copy link
Collaborator

daanvdk commented Feb 17, 2022

https://github.com/CodeYellowBV/django-binder/blob/master/binder/views.py#L1721

This line makes us ignore values sent for annotations, however the problem is that this will only return the annotations requested by the current request. In a lot of cases we do send values for optional annotations while we do not request them to be returned, these are now not ignored and should also be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant