Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete CaseInsensitiveCharField once we can use CITextField #9

Open
sjamaan opened this issue Aug 15, 2016 · 4 comments
Open

Delete CaseInsensitiveCharField once we can use CITextField #9

sjamaan opened this issue Aug 15, 2016 · 4 comments

Comments

@sjamaan
Copy link
Contributor

sjamaan commented Aug 15, 2016

Some upcoming version of Django will have a CITextField. Then we can get rid of our CaseInsensitiveCharField.

@sjamaan
Copy link
Contributor Author

sjamaan commented Oct 18, 2016

Oh my, looky here

@sjamaan sjamaan changed the title CaseInsensitiveCharField is misnamed Delete CaseInsensitiveCharField once we can use CITextField Oct 18, 2016
@irfinnew
Copy link

irfinnew commented Oct 18, 2016

\o\
/o/
\o/

@irfinnew
Copy link

This is actually part of the now-released Django 1.11.

See https://docs.djangoproject.com/en/1.11/releases/1.11/#django-contrib-postgres

@sjamaan
Copy link
Contributor Author

sjamaan commented Nov 20, 2017

I've added a deprecation warning to point people in the right direction.

I'll leave this ticket open until there is no longer any project that actually uses it. We'll also need to consider what to do with any migrations that might possibly be using it (it would be easy to just rewrite them to use CharField or something; there should always be a later migration to use CITextField, so that's actually safe, but still annoying).

NOTE: I had to add psycopg2 to the dependencies to make this work, because otherwise we can't even import CITextField. We should really consider dropping all support for sqlite, as we don't even use it in any of our projects, and it might start hampering our ability to make full use of all Postgres goodness offered by Django (for example, now we can't add a test for the case insensitive fields).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants