refactor: remove reduce and add Math.max to find the highest position

Codeminer42 · Aug 12, 2024 · c662595 · c662595
1 parent 857203c
commit c662595
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/app/assets/javascripts/models/beta/story.js b/app/assets/javascripts/models/beta/story.js
@@ -142,11 +142,8 @@ export const getHighestNewPosition = stories => {
   if (stories.length === 1) {
     return 1;
   }
-  const highestPositionValue = stories
-    .filter(story => story.newPosition !== null)
-    .reduce((acc, story) => {
-      return story.newPosition > acc ? story.newPosition : acc;
-    }, stories[0].newPosition);
+  const storiesNewPosition = stories.map(story => story.newPosition);
+  const highestPositionValue = Math.max(...storiesNewPosition);
 
   return highestPositionValue + 1;
 };