Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHN-BS-34 #82

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

UHN-BS-34 #82

wants to merge 13 commits into from

Conversation

andrchoi
Copy link
Contributor

Generates a CSV file from PostgreSQL data and emails it to a given address.

@andrchoi andrchoi requested a review from Asiapenguin May 11, 2020 17:52
Copy link
Contributor

@Asiapenguin Asiapenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. This wouldnt work when the csv is too big, i.e. bigger than the maximum allowance of email messages + attachments. I think its around 25mb to 35mb. I am assuming it would quickly reach that number and all the emails will error out. What do you think could be the solution?

Copy link
Contributor

@Asiapenguin Asiapenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the .gitkeep for?

@andrchoi
Copy link
Contributor Author

It's to add the metricData folder to git. If you don't want it there's a package that creates a directory instead.

Copy link
Contributor

@Asiapenguin Asiapenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change setTimeout to a node-cron job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants