Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing code #30

Open
7 tasks
KlavierCat opened this issue Feb 21, 2017 · 0 comments
Open
7 tasks

Refactor existing code #30

KlavierCat opened this issue Feb 21, 2017 · 0 comments
Assignees
Milestone

Comments

@KlavierCat
Copy link
Contributor

KlavierCat commented Feb 21, 2017

TODO:

  • Naming: currently there are both Id and ID. We need to unify this, both in app.js and the faked DB. Function names can be improved to make more sense
  • add comment, use Javadoc format.
  • Stay DRY: try to abstract away anything that is repetitive in our current code
  • if they are constants, do not use var, use const
  • refactor long function. Functions shouldn't be too long and each function should do only one thing.
  • Reorder: both consts / vars and function. In an order that makes more senses.
  • If necessary, separate the code into different modules and use "require" to require them. Probably not necessary at this stage.
@KlavierCat KlavierCat added this to the delta milestone Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants