Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

IMediaServiceProvider-Image extensions #128

Open
Drjoachim opened this issue Apr 3, 2020 · 3 comments
Open

IMediaServiceProvider-Image extensions #128

Drjoachim opened this issue Apr 3, 2020 · 3 comments

Comments

@Drjoachim
Copy link
Contributor

Currently looks like this:

 public interface IMediaServiceProvider
    {
        MediaType SupportedType { get; }
        Task<IEnumerable<MediaItem>> GetItems(string tenantId);
        Task PersistMediaFile(UserInfo userInfo, string mediaUrl);
        Task PersistTextMessage(UserInfo userInfo, TextMessage message);
    }

=> But since we are aiming to implement video #125 ; shouldnt it be changed to:

 public interface IMediaServiceProvider
    {
        MediaType SupportedType { get; }
        Task<IEnumerable<MediaItem>> GetItems(string tenantId);
        Task PersistImageFile(UserInfo userInfo, string mediaUrl, string contentType);
        Task PersistTextMessage(UserInfo userInfo, TextMessage message);
        Task PersistVideoFile(UserInfo userInfo, string mediaUrl, string contentType);
    }

with contentype containing the Mimetype.

I was working on #67 and was just wondering how to properly solve this and if you approve

@Drjoachim Drjoachim changed the title IMediaServiceProvider IMediaServiceProvider-Image extensions Apr 3, 2020
@Drjoachim
Copy link
Contributor Author

@tomkerkhove
Copy link
Contributor

I think we need to refactor them into IVideoProvider, ITextMessageProvider & IImageProvider with their dedicated methods aligned to the needs, no?

@Drjoachim
Copy link
Contributor Author

Makes more sense indeed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants