-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of LanceDB with PR-agent for managing database #523
Conversation
Thanks @PrashantDixit0 |
/review |
/describe |
PR Description updated to latest commit (476fad8) |
PR Analysis
PR Feedback
How to useInstructions
|
ok sure @mrT23 |
@@ -14,6 +14,7 @@ max_model_tokens = 32000 # Limits the maximum number of tokens that can be used | |||
patch_extra_lines = 3 | |||
secret_provider="google_cloud_storage" | |||
cli_mode=false | |||
vectordb = "lancedb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to
[pr_similar_issue]
@@ -0,0 +1,2 @@ | |||
{ | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this file ? why to you add it ?
@@ -14,6 +14,7 @@ msrest==0.7.1 | |||
openai==0.27.8 | |||
pinecone-client | |||
pinecone-datasets @ git+https://github.com/mrT23/pinecone-datasets.git@main | |||
lancedb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lock versrion
lancedb==0.3.4
Hi @PrashantDixit0 . i gave some code comments, but in addition:
If there is a threshold to be set, make it configurable. but you must demonstrate that the tool indeed works, and can retrieve reasonable similar issues
|
Sure @mrT23, I'll work on your comments |
Type
Enhancement
Description
This PR integrates LanceDB with PR-agent to manage the database more seamlessly. The main changes include:
PR changes walkthrough
1 files
pr_similar_issue.py
pr_agent/tools/pr_similar_issue.py
The PRSimilarIssue class has been modified to support
LanceDB operations. This includes checking if the index
exists, indexing the entire repo, updating the index if
needed, and querying using LanceDB. A new method,
_update_table_with_issues, has been added to update the
table with issues when LanceDB is used.
1 files
configuration.toml
pr_agent/settings/configuration.toml
The configuration file has been updated to include LanceDB
as a vector database option. The URI for LanceDB has also
been added.
1 files
requirements.txt
requirements.txt
LanceDB has been added to the project dependencies.
1 files
settings.json
.vscode/settings.json
The settings file has been modified, but no significant
changes have been made.