Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr-agent-review.yaml #531

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update pr-agent-review.yaml #531

merged 1 commit into from
Dec 18, 2023

Conversation

hussam789
Copy link
Collaborator

@hussam789 hussam789 commented Dec 18, 2023

Type

Enhancement


Description

This PR disables the GitHub Actions triggered by pull requests and issue comments. Instead, it enables the workflow dispatch event, which allows the workflow to be manually triggered from GitHub's UI. This change provides more control over when the workflow is executed, reducing unnecessary runs and potentially saving resources.


PR changes walkthrough

Relevant files                                                                                                                                 
Configuration changes
1 files
pr-agent-review.yaml                                                                               
    .github/workflows/pr-agent-review.yaml

    The pull_request and issue_comment triggers have been
    commented out, and the workflow_dispatch trigger has been
    added. This means that the workflow will no longer
    automatically run on pull requests or issue comments, but
    can be manually triggered from the GitHub UI.
+3/-2

@hussam789 hussam789 requested a review from mrT23 December 18, 2023 11:38
@qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Dec 18, 2023
Copy link
Contributor

PR Description updated to latest commit (9d2003d)

Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Disabling GitHub Actions triggered by pull requests and issue comments
  • 📝 PR summary: This PR modifies the GitHub Actions configuration to disable automatic triggering by pull requests and issue comments. Instead, it enables manual triggering via the workflow dispatch event from GitHub's UI.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR only involves a simple configuration change in a single file.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is straightforward and the changes are clearly explained in the PR description. However, it would be helpful to provide a brief explanation of why these changes are necessary in the PR description. This could include the benefits of manually triggering workflows over automatic triggering.

  • 🤖 Code feedback:
    relevant file.github/workflows/pr-agent-review.yaml
    suggestion      Consider leaving a comment explaining why the automatic triggers are commented out. This will provide context to other developers who might be looking at this configuration in the future. [medium]
    relevant line# pull_request:

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

@hussam789 hussam789 merged commit 2ac86f4 into main Dec 18, 2023
4 checks passed
@hussam789 hussam789 deleted the disable_github_action branch December 18, 2023 11:39
yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants