-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring AI Handlers and Adding Support for Multiple AI Models #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method This commit refactors the PRAgent class and the has_ai_handler_param method. The has_ai_handler_param method is moved outside the class and made a standalone function. This change improves code organization and readability. The has_ai_handler_param function now takes a class object as a parameter and checks if the class constructor has an "ai_handler" parameter. This refactoring is done to streamline the code and improve its maintainability. No issue references.
…fy AI handler injection in PRAgent
github-actions
bot
changed the title
Tr/ai handler
Refactoring AI Handlers and Adding Support for Multiple AI Models
Dec 14, 2023
…hub_action_runner.py
/describe |
PR Description updated to latest commit (02871b1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Type
Enhancement
Description
This PR introduces significant changes to the AI handling system of the PR Agent. The main changes include:
BaseAiHandler
to define a common interface for all AI handlers.OpenAIHandler
,LangChainOpenAIHandler
, andLiteLLMAIHandler
. These handlers are designed to interact with different AI models.PRAgent
and related classes to support the new AI handlers. The AI handler to be used can now be injected into these classes upon instantiation.langchain
package to the requirements (commented out as it's optional).PR changes walkthrough
13 files
base_ai_handler.py
pr_agent/algo/ai_handlers/base_ai_handler.py
Introduced a new abstract base class `BaseAiHandler` that
defines a common interface for all AI handlers. This class
includes an abstract `chat_completion` method that all
subclasses must implement.
openai_ai_handler.py
pr_agent/algo/ai_handlers/openai_ai_handler.py
Added a new `OpenAIHandler` class that extends
`BaseAiHandler`. This class is designed to interact with the
OpenAI API for chat completions.
langchain_ai_handler.py
pr_agent/algo/ai_handlers/langchain_ai_handler.py
Added a new `LangChainOpenAIHandler` class that extends
`BaseAiHandler`. This class is designed to interact with the
LangChain AI model.
litellm_ai_handler.py
pr_agent/algo/ai_handlers/litellm_ai_handler.py
Renamed `AiHandler` to `LiteLLMAIHandler` and made it extend
`BaseAiHandler`. This class is designed to interact with the
LiteLLM AI model.
pr_agent.py
pr_agent/agent/pr_agent.py
Modified the `PRAgent` class to support the new AI handlers.
The AI handler to be used can now be injected into this
class upon instantiation.
pr_reviewer.py
pr_agent/tools/pr_reviewer.py
Modified the `PRReviewer` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_description.py
pr_agent/tools/pr_description.py
Modified the `PRDescription` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_generate_labels.py
pr_agent/tools/pr_generate_labels.py
Modified the `PRGenerateLabels` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_code_suggestions.py
pr_agent/tools/pr_code_suggestions.py
Modified the `PRCodeSuggestions` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_update_changelog.py
pr_agent/tools/pr_update_changelog.py
Modified the `PRUpdateChangelog` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_add_docs.py
pr_agent/tools/pr_add_docs.py
Modified the `PRAddDocs` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
pr_information_from_user.py
pr_agent/tools/pr_information_from_user.py
Modified the `PRInformationFromUser` class to support the
new AI handlers. The AI handler to be used can now be
injected into this class upon instantiation.
pr_questions.py
pr_agent/tools/pr_questions.py
Modified the `PRQuestions` class to support the new AI
handlers. The AI handler to be used can now be injected into
this class upon instantiation.
1 files
requirements.txt
requirements.txt
Added the `langchain` package to the requirements (commented
out as it's optional).
Type
enhancement
Description
BaseAiHandler
and specific implementations for LiteLLM (LiteLLMAIHandler
), OpenAI (OpenAIHandler
), and LangChain (LangChainOpenAIHandler
).PRAgent
and related tools (PRAddDocs
,PRCodeSuggestions
, etc.) to use dependency injection for AI handlers, allowing for flexible AI model usage.requirements.txt
accordingly.Changes walkthrough
pr_agent.py
Refactor PRAgent to Use New AI Handler System
pr_agent/agent/pr_agent.py
BaseAiHandler
andLiteLLMAIHandler
for AI handling.ai_handler
parameter toPRAgent
constructor for dependencyinjection.
handle_request
method to useai_handler
for AI operations.base_ai_handler.py
Introduce BaseAiHandler Abstract Class
pr_agent/algo/ai_handlers/base_ai_handler.py
BaseAiHandler
defining the interfacefor AI handlers.
langchain_ai_handler.py
Add LangChain AI Handler Implementation
pr_agent/algo/ai_handlers/langchain_ai_handler.py
LangChainOpenAIHandler
extendingBaseAiHandler
.litellm_ai_handler.py
Update LiteLLM AI Handler to New Interface
pr_agent/algo/ai_handlers/litellm_ai_handler.py
AiHandler
toLiteLLMAIHandler
and made it extendBaseAiHandler
.chat_completion
method to align with the new interface.openai_ai_handler.py
Implement OpenAI Handler
pr_agent/algo/ai_handlers/openai_ai_handler.py
OpenAIHandler
class extendingBaseAiHandler
.and retries.
pr_add_docs.py
Refactor PRAddDocs to Use Injected AI Handler
pr_agent/tools/pr_add_docs.py
ai_handler
parameter to constructor for dependency injection.utils.py
Minor Formatting Fix in Utils
pr_agent/algo/utils.py
clip_tokens
function.requirements.txt
Update Requirements with Optional LangChain Dependency
requirements.txt
langchain
package to requirements.✨ Usage guide:
Overview:
The
describe
tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_description
section), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describe
tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.the tool will replace every marker of the form
pr_agent:marker_name
in the PR description with the relevant content, wheremarker_name
is one of the following:type
: the PR type.summary
: the PR summary.walkthrough
: the PR walkthrough.Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describe
tool are quite generic: [Bug fix
,Tests
,Enhancement
,Documentation
,Other
].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance
- pr_agent:The main topic of this PR is performanceNew endpoint
- pr_agent:A new endpoint was added in this PRSQL query
- pr_agent:A new SQL query was added in this PRDockerfile changes
- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describe
tool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summary
in the configuration file, possible values are:'table'
: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true
: A collapsable file comment with changes title and a changes summary for each file in the PR.false
(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describe
tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.