Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RidgeMap bbox documentation misleading #16

Open
coolum001 opened this issue May 23, 2019 · 2 comments
Open

RidgeMap bbox documentation misleading #16

coolum001 opened this issue May 23, 2019 · 2 comments

Comments

@coolum001
Copy link

HI

First, very impressive outputs.

Second, using RidgeMap downloaded from GITHUB 23 5 2019,
the doc string for RidgeMap states:

----------
bbox : list-like of length 4
    In the form (lat, long, lat, long), describing the
    (bottom_left, top_right) corners of a box.
    http://bboxfinder.com is a useful way to find these tuples.
font : matplotlib.font_manager.FontProperties
    Optional, a custom font to use. Defaults to Cinzel Regular.
File:           c:\users\donrc\documents\jupyternotebooks\ridgemapprojectnotebookproject\develop\ridge_map\ridge_map.py
Type:           type
Subclasses:     

I think it is actually long, lat (eg X, Y) in the pairs for the bbox tuple

Environment:

python version : 3.7.1 (default, Dec 10 2018, 22:54:23) [MSC v.1915 64 bit (AMD64)]
python environment : ac5-py37
pandas version : 0.23.4
current wkg dir: C:\Users\donrc\Documents\JupyterNotebooks\RidgeMapProjectNotebookProject\develop
Notebook name: 2019-05-23-dc-RidgeMapNotebook.ipynb
Notebook run at: 2019-05-23 21:41:38.600014 local time
Notebook run at: 2019-05-23 11:41:38.600014 UTC
Notebook run on: Windows-10-10.0.17134-SP0
@ColCarroll
Copy link
Owner

You're right -- thanks for catching this, and thanks for your kind words. Would you like to submit a patch to fix this? I can do it if not.

@coolum001
Copy link
Author

coolum001 commented May 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants