removed: no longer calculate total view counts on plugin settings page

On large sites with a lot of history these counts take increasingly more
time to calculate, resulting in time outs.

Author: jdalsem

languages/en.php

@@ -5,7 +5,6 @@
 
 	'entity_view_counter:settings:description' => "In order to track the views of an entity type, please check it below. If you enable a new plugin you may have to check back here, because by default the entity type will NOT be tracked.",
 	'entity_view_counter:settings:entity_type' => "Entity type to be tracked",
-	'entity_view_counter:settings:num_views' => "Total number of views",
 	'entity_view_counter:settings:delete' => "Remove all tracked views",
 
 	'entity_view_counter:stats:title' => "Statistics",

languages/nl.php

@@ -20,7 +20,6 @@
   'entity_view_counter:stats:lastyear' => 'Vorig jaar',
   'entity_view_counter:stats:chart:recent' => 'Recente weergaven',
   'entity_view_counter:stats:chart:years' => 'Jaar totalen',
-  'entity_view_counter:settings:num_views' => 'Totaal aantal weergaven',
   'entity_view_counter:settings:delete' => 'Verwijder alle gevolgde weergaven',
   'entity_view_counter:action:admin:reset_counter:success' => 'Alle gevolgde weergaven zijn verwijderd',
   'entity_view_counter:entity:menu:views' => '%s weergaven',

views/default/plugins/entity_view_counter/settings.php

@@ -1,41 +1,12 @@
 <?php
 
-use Elgg\Database\Select;
-
-$object_types = elgg_extract('object', elgg_entity_types_with_capability('searchable'), []);
-
 echo elgg_view('output/longtext', [
 	'value' => elgg_echo('entity_view_counter:settings:description'),
 ]);
 
-// get counts for all subtypes
-// this could take a while
-set_time_limit(0);
-
-$select = Select::fromTable('annotations', 'a');
-$e = $select->joinEntitiesTable('a', 'entity_guid');
-$select->select('count(*) as total')
-	->addSelect("{$e}.type")
-	->addSelect("{$e}.subtype")
-	->where($select->compare("{$e}.type", '=', 'object', ELGG_VALUE_STRING))
-	->andWhere($select->compare("{$e}.subtype", 'in', $object_types, ELGG_VALUE_STRING))
-	->andWhere($select->compare('a.name', '=', ENTITY_VIEW_COUNTER_ANNOTATION_NAME, ELGG_VALUE_STRING))
-	->groupBy("{$e}.type")
-	->addGroupBy("{$e}.subtype");
-
-$counts = elgg()->db->getData($select, function ($row) {
-	return (array) $row;
-});
-// order counts into easier format
-$ordered_counts = [];
-foreach ($counts as $count) {
-	$ordered_counts[$count['subtype']] = (int) $count['total'];
-}
-
 // listing
 $row = [
 	elgg_format_element('th', [], elgg_echo('entity_view_counter:settings:entity_type')),
-	elgg_format_element('th', ['class' => 'center'], elgg_echo('entity_view_counter:settings:num_views')),
 	elgg_format_element('th', ['class' => 'center'], elgg_echo('entity_view_counter:settings:delete')),
 ];
 
@@ -48,6 +19,8 @@
 ]);
 
 $rows = [];
+
+$object_types = elgg_extract('object', elgg_entity_types_with_capability('searchable'), []);
 foreach ($object_types as $subtype) {
 	$row = [];
 
@@ -60,23 +33,16 @@
 		'switch' => true,
 	]));
 
-	$count = elgg_extract($subtype, $ordered_counts, 0);
-	$row[] = elgg_format_element('td', ['class' => 'center'], $count);
-	
-	if ($count > 0) {
-		$row[] = elgg_format_element('td', ['class' => 'center'], elgg_view('output/url', [
-			'text' => false,
-			'href' => elgg_generate_action_url('entity_view_counter/admin/reset_counter', [
-				'subtype' => $subtype,
-			]),
-			'icon' => 'delete',
-			'title' => elgg_echo('delete'),
-			'confirm' => elgg_echo('deleteconfirm:plural'),
-			'class' => 'entity-view-counter-reset',
-		]));
-	} else {
-		$row[] = elgg_format_element('td', [], '&nbsp;');
-	}
+	$row[] = elgg_format_element('td', ['class' => 'center'], elgg_view('output/url', [
+		'text' => false,
+		'href' => elgg_generate_action_url('entity_view_counter/admin/reset_counter', [
+			'subtype' => $subtype,
+		]),
+		'icon' => 'delete',
+		'title' => elgg_echo('delete'),
+		'confirm' => elgg_echo('deleteconfirm:plural'),
+		'class' => 'entity-view-counter-reset',
+	]));
 
 	$rows[] = elgg_format_element('tr', [], implode(PHP_EOL, $row));
 }