fixed: unable to unset all tracked entity types

Author: jeabakker

classes/ColdTrick/EntityViewCounter/Settings.php

@@ -12,19 +12,19 @@ class Settings {
 	 *
 	 * @param \Elgg\Event $event 'setting', 'plugin'
 	 *
-	 * @return array
+	 * @return null|string
 	 */
-	public static function saveSettingEntityTypes(\Elgg\Event $event) {
-		
+	public static function saveSettingEntityTypes(\Elgg\Event $event): ?string {
 		$plugin = $event->getParam('plugin');
 		if (!$plugin instanceof \ElggPlugin || $plugin->getID() !== 'entity_view_counter') {
-			return;
+			return null;
 		}
 
-		if ($event->getParam('name') !== 'entity_types') {
-			return;
+		$value = $event->getValue();
+		if ($event->getParam('name') !== 'entity_types' && !is_array($value)) {
+			return null;
 		}
 
-		return json_encode($event->getParam('value'));
+		return json_encode($value);
 	}
 }

views/default/plugins/entity_view_counter/settings.php

@@ -41,6 +41,12 @@
 
 $header = elgg_format_element('thead', [], elgg_format_element('tr', [], implode(PHP_EOL, $row)));
 
+// need an empty input in order to be able to unset everything
+echo elgg_view_field([
+	'#type' => 'hidden',
+	'name' => 'params[entity_types]',
+]);
+
 $rows = [];
 foreach ($object_types as $subtype) {
 	$row = [];