Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All URL is case-sensitive within the applause-button #89

Open
LazyRen opened this issue Feb 5, 2022 · 1 comment
Open

All URL is case-sensitive within the applause-button #89

LazyRen opened this issue Feb 5, 2022 · 1 comment

Comments

@LazyRen
Copy link

LazyRen commented Feb 5, 2022

IMHO, some part must not be taken as case-sensitve.

I just noticed this while playing around with #33.

I have reconfigured my blog setting to use lowercase for the hostname. (e.g. LazyRen.github.io/post-link -> lazyren.github.io/post-link)
But unfortunatelly, this erased all previously stored clap-count...

~/blog master                                                                                                                                                                                                                                                                 
❯ curl 'https://api.applause-button.com/get-multiple' \
  -H 'Content-Type: text/plain' --data-binary \
'["Applause-button.com/"]'        
[]%                                                                                                                                                                                                                                                                            

~/blog master                                                                                                                                                                                                                                                                 
❯ curl 'https://api.applause-button.com/get-multiple' \
  -H 'Content-Type: text/plain' --data-binary \
'["applause-button.com/"]'
[{"claps":42135,"sourceIp":"37.120.201.188","url":"applause-button.com/"}]%      
@LazyRen LazyRen changed the title All url is case-sensitive within the applause-button All URL is case-sensitive within the applause-button Feb 5, 2022
@chriswilty
Copy link
Collaborator

That's a fair comment, and should be easy to remedy. The fix would need to be done over in applause-button-server.

@LazyRen Would you mind adding an issue over there? Feel free to link back to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants