UI: fix rename dialog flickering

problem: rename dialog sometimes flickered in Firefox it flickered when the button label was clicked, it made the event bubble and triggered the click event multiple times. trying to open dialog when already opened makes it flicker intentionally fixes: #7479 Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: I290c905ac321650bd7979495c78de7d66f188ffd
CollaboraOnline · Oct 26, 2023 · 7434cb0 · 7434cb0
1 parent 83c490b
commit 7434cb0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/browser/src/control/Control.JSDialogBuilder.js b/browser/src/control/Control.JSDialogBuilder.js
@@ -2611,7 +2611,8 @@ L.Control.JSDialogBuilder = L.Control.extend({
 
 		$(control.container).unbind('click.toolbutton');
 		if (!builder.map.isLockedItem(data)) {
-			$(control.container).click(function () {
+			$(control.container).click(function (e) {
+				e.preventDefault();
 				builder.map.dispatch(data.command);
 			});
 		}