From 7434cb0e658df4a944260af5bb50f0fa63cccdf6 Mon Sep 17 00:00:00 2001 From: Pranam Lashkari Date: Thu, 26 Oct 2023 07:54:49 +0530 Subject: [PATCH] UI: fix rename dialog flickering problem: rename dialog sometimes flickered in Firefox it flickered when the button label was clicked, it made the event bubble and triggered the click event multiple times. trying to open dialog when already opened makes it flicker intentionally fixes: #7479 Signed-off-by: Pranam Lashkari Change-Id: I290c905ac321650bd7979495c78de7d66f188ffd --- browser/src/control/Control.JSDialogBuilder.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/browser/src/control/Control.JSDialogBuilder.js b/browser/src/control/Control.JSDialogBuilder.js index 3374e08fac5b..fc4267eda7b2 100644 --- a/browser/src/control/Control.JSDialogBuilder.js +++ b/browser/src/control/Control.JSDialogBuilder.js @@ -2611,7 +2611,8 @@ L.Control.JSDialogBuilder = L.Control.extend({ $(control.container).unbind('click.toolbutton'); if (!builder.map.isLockedItem(data)) { - $(control.container).click(function () { + $(control.container).click(function (e) { + e.preventDefault(); builder.map.dispatch(data.command); }); }