-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to bootstrap 5 #59
Comments
@owikle @dcnb PRs are poised on -GH, -CSV, -Sheets, and cb-docs for bootstrap 5 update. Let me know if you have any concerns before I merge them all! |
p.s. I did not do -CONTENTdm. |
Most of the changes look good but it's sad that the colors are so ugly. I especially don't like that primary clashes with the remaining info elements, like timeline highlight and featured image link--maybe we should change those too? I also fixed a forgotten info button on the about page in gh and csv. |
I'd like to get a few palettes together for this:
https://huemint.com/bootstrap-plus/
this site looks promising for doing this, and I'm wondering if we can use
the work Evan's already done with the color theming to implement some built
in options. Users like to customize the look, that's for sure -- I think
it'd be great if we could lean more this way and less bootswatch way. Maybe
aim for four palettes, one a Vandal Gold? And then vet those for
accessibility/readability. Maybe it's time to bring someone with a really
good color/design sense in?
…On Tue, May 3, 2022 at 4:08 PM owikle ***@***.***> wrote:
Most of the changes look good but it's sad that the colors are so ugly. I
especially don't like that primary clashes with the remaining info
elements, like timeline highlight and featured image link--maybe we should
change those too? I also fixed a forgotten info button on the about page in
gh and csv.
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTM4GP3PY426K5ZXJLFZI3VIGWW3ANCNFSM5RSV2LQA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think two simple approaches that could work well:
|
honestly though, I didn't like the |
Actually, thinking about it a bit more, another good option: |
option 2 is best if we are using some external generator to produce bootstrap themes, |
For option 2, combine Huemint generator with bootstrap build to get ready to use themed bootstrap.min.css |
moved theme discussion to main CB repo issue |
@owikle @dcnb take a look at branch
bootstrap-upgrade
migrating to bootstrap 5:
The text was updated successfully, but these errors were encountered: