Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to bootstrap 5 #59

Closed
6 tasks done
evanwill opened this issue Mar 25, 2022 · 10 comments
Closed
6 tasks done

migrate to bootstrap 5 #59

evanwill opened this issue Mar 25, 2022 · 10 comments

Comments

@evanwill
Copy link
Contributor

evanwill commented Mar 25, 2022

@owikle @dcnb take a look at branch bootstrap-upgrade

migrating to bootstrap 5:

  • update assets
  • remove jquery and fix all js
  • update icons to bs-icons
  • color theming
  • test theme options
  • test includes
@evanwill
Copy link
Contributor Author

evanwill commented May 3, 2022

@owikle @dcnb PRs are poised on -GH, -CSV, -Sheets, and cb-docs for bootstrap 5 update. Let me know if you have any concerns before I merge them all!
The style looks a bit different, wider container, slightly different fonts, colors accessible but uglier.
I removed all btn-info because they are ugly, and all btn-outline-info since they aren't accessible except on dark background.

@evanwill
Copy link
Contributor Author

evanwill commented May 3, 2022

p.s. I did not do -CONTENTdm.

@owikle
Copy link
Contributor

owikle commented May 3, 2022

Most of the changes look good but it's sad that the colors are so ugly. I especially don't like that primary clashes with the remaining info elements, like timeline highlight and featured image link--maybe we should change those too? I also fixed a forgotten info button on the about page in gh and csv.

@dcnb
Copy link
Contributor

dcnb commented May 3, 2022 via email

@evanwill
Copy link
Contributor Author

evanwill commented May 4, 2022

I think two simple approaches that could work well:

  1. have a set of values documented you could paste into "config-theme-colors.csv" that make a logical set of changes (or downloadable csvs of themes). i.e. the theming just basically swaps out the btn colors (it currently generates btn-, btn-outline-, text-, and bg- classes. we could probably add link and text classes easily. to make it work well, we just need to more carefully apply all the bs color values across the template elements)
  2. have a set of custom css (like from that bootstrap-plus generator) that does similar thing to bootswatch, but less extreme, more logical color themeing--and handle it exactly how the bootswatch option is currently. The extra css are pre generated, and are just in the assets. there are like 2 - 4 options that we figure out.

@evanwill
Copy link
Contributor Author

evanwill commented May 4, 2022

honestly though, I didn't like the info btns anyway now that I look at them closely! It is hard to read. I think we just had them because originally we were using UofI "Clearwater Blue", and then I wanted to de-customize the colors, and info was practically the same color...

@evanwill
Copy link
Contributor Author

evanwill commented May 4, 2022

Actually, thinking about it a bit more, another good option:
3. have a set of theme scss in "_sass", choose one in "theme.yml" just like choosing bootswatch. Having it in _sass would let you set up some custom theme options, plus the theme file could use the theme-color utilities without adding something to "config-theme-colors.csv". swapping them out happens in "assets/css/custom.scss".

@evanwill
Copy link
Contributor Author

evanwill commented May 4, 2022

option 2 is best if we are using some external generator to produce bootstrap themes,
option 3 if we are just setting it up ourselves

@evanwill
Copy link
Contributor Author

evanwill commented May 4, 2022

For option 2, combine Huemint generator with bootstrap build to get ready to use themed bootstrap.min.css

@evanwill
Copy link
Contributor Author

evanwill commented May 5, 2022

moved theme discussion to main CB repo issue

@evanwill evanwill closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants