From 7f258aede61cbdcb0a18e8ca7b253f85f0642247 Mon Sep 17 00:00:00 2001 From: Angelika Serwa Date: Fri, 10 Jan 2025 18:35:11 +0100 Subject: [PATCH] [native] Fix video in VideoPlaybackModal displayed incorrectly Summary: https://linear.app/comm/issue/ENG-10078/invalid-video-size-in-videoplaybackmodal-on-android The screenshot and explanation is included in linear ticket above. Adding `resizeMode` fixed the issue. Test Plan: Display some videos in `VideoPlaybackModal` on iOS and Android. Reviewers: bartek, tomek, ashoat Reviewed By: ashoat Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14191 --- native/media/video-playback-modal.react.js | 1 + 1 file changed, 1 insertion(+) diff --git a/native/media/video-playback-modal.react.js b/native/media/video-playback-modal.react.js index b893e772da..d091e85269 100644 --- a/native/media/video-playback-modal.react.js +++ b/native/media/video-playback-modal.react.js @@ -725,6 +725,7 @@ function VideoPlaybackModal(props: Props): React.Node { onProgress={progressCallback} onEnd={resetVideo} onReadyForDisplay={readyForDisplayCallback} + resizeMode="contain" /> ); }