Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration proposal - ClamAv antivirus #102

Open
csharpfritz opened this issue Oct 16, 2024 · 10 comments · May be fixed by #412
Open

Integration proposal - ClamAv antivirus #102

csharpfritz opened this issue Oct 16, 2024 · 10 comments · May be fixed by #412
Labels
good first issue Good for newcomers integration A new .NET Aspire integration

Comments

@csharpfritz
Copy link

csharpfritz commented Oct 16, 2024

.NET Aspire issue link

No response

Overview

I've started an integration sample that uses ClamAv anti-malware to scan file uploads for malware. Source at: https://github.com/csharpfritz/aspireantivirus

Would the team be interested in a contribution of that initial sample code and formalizing the feature?

Usage example

This integration could be used to scan uploads to a service to ensure that no malware is included

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item

@aaronpowell
Copy link
Member

AV to scan user provided files makes a lot of sense and you're making me question why I've never done that in a project before 🤣.

Would be happy to have it as a contribution, I notice your repo has a hosting integration only and the client is more directly using the client for ClamAV rather than an Aspire client integration. Would it make sense to also include a client integration to simplify the workflow of consuming it?

@aaronpowell aaronpowell added the integration A new .NET Aspire integration label Oct 17, 2024
@aaronpowell aaronpowell added good first issue Good for newcomers awaiting response Waiting for the author of the issue to provide more information or answer a question labels Oct 27, 2024
@csharpfritz
Copy link
Author

You're right, we should put together a client implementation as well... and I started one, then got a little confused. I could use some assistance in tightening that client implementation, and would be happy to share the work I started.

@aaronpowell
Copy link
Member

If you want to get a pull request up @csharpfritz we can help iterate and refine it

@dansiegel
Copy link

AV to scan user provided files makes a lot of sense and you're making me question why I've never done that in a project before 🤣.

I'm with @aaronpowell... I would LOVE to see this and happy to lend a hand if needed

@csharpfritz
Copy link
Author

csharpfritz commented Nov 15, 2024 via email

Copy link

github-actions bot commented Dec 7, 2024

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it.

@github-actions github-actions bot added the Stale label Dec 7, 2024
@csharpfritz
Copy link
Author

I'll put together that PR with the nClam support this week

@github-actions github-actions bot removed the Stale label Dec 12, 2024
Copy link

github-actions bot commented Jan 3, 2025

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it.

@github-actions github-actions bot added the Stale label Jan 3, 2025
Copy link

This issue has been stale for 5 weeks and has been automatically closed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2025
@csharpfritz
Copy link
Author

I'm submitting a PR for this now

@csharpfritz csharpfritz linked a pull request Jan 22, 2025 that will close this issue
10 tasks
@csharpfritz csharpfritz changed the title Integration proposal - nClam antivirus Integration proposal - ClamAv antivirus Jan 22, 2025
@Alirexaa Alirexaa reopened this Jan 22, 2025
@Alirexaa Alirexaa removed awaiting response Waiting for the author of the issue to provide more information or answer a question Stale labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers integration A new .NET Aspire integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants