Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the devcontainers dotnet feature version #488

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix the devcontainers dotnet feature version #488

merged 1 commit into from
Feb 18, 2025

Conversation

TechWatching
Copy link
Contributor

Closes #487

Modify the additionalVersions property value of the dotnet feature in the devcontainer.json

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Contains NO breaking changes
  • Code follows all style conventions

@TechWatching
Copy link
Contributor Author

@dotnet-policy-service agree

aaronpowell
aaronpowell approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird, not having this problem on mine... but looking at the docs it should be a comma-separated string not an array.

@aaronpowell aaronpowell merged commit c936d7e into CommunityToolkit:main Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronpowell aaronpowell aaronpowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running devcontainer does not work because of the
2 participants
@TechWatching @aaronpowell