Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slngen tooling to generate solution file #257

Closed
Arlodotexe opened this issue Aug 10, 2022 · 4 comments
Closed

Use slngen tooling to generate solution file #257

Arlodotexe opened this issue Aug 10, 2022 · 4 comments
Assignees
Labels
CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Aug 10, 2022

Describe the proposed changes

Right now, we're using a PowerShell + a templated version of our previous (Visual Studio generated) solution file.

This is hard to extend and maintain. Instead, we should investigate using the slngen tool instead (see here).

Additional context

This will make CommunityToolkit/Tooling-Windows-Submodule#17 much easier.

@michael-hawker
Copy link
Member

Looks like the shared projects are going to be an issue with slngen (both for the sample app heads and the tests), from #350:

"D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\CommunityToolkit.Labs.Shared.shproj" (default target) (26) ->
(Build target) -> 
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\CodeSharing\Microsoft.SharedProject.Common.targets(15,5): error MSB3871: Shared projects cannot be built on their own.  Please either build a project that references this project, or build the entire solution. [D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\CommunityToolkit.Labs.Shared.shproj]

@michael-hawker
Copy link
Member

Shared projects loading with new version now, though WinAppSDK tests not running, so not sure what's going on there...

@michael-hawker
Copy link
Member

Huh, @Arlodotexe do running the WinAppSDK tests in the all solution work for you? Wonder if something happened and we need to update to the latest (part of the PR I was doing for #183...).

I tried on another branch without slngen and it didn't seem to work. Will check the CI when I update my PR for #350.

@michael-hawker
Copy link
Member

Think main limitation now is the platform configuration generation in slngen, see microsoft/slngen#437 and a nice-to-have: microsoft/slngen#438

Our current solution's config for reference in future:

image

image

ARM/ARM64 missing is the biggest issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Windows Community Toolkit Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/pipeline 🔬 dev loop ➰ For issues that impact the core dev-loop of building experiments enhancement Improvement to an existing feature
Projects
Status: Done
Development

No branches or pull requests

2 participants