Clean-up Solution Generation PowerShell Script #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to jborean from the PowerShell Discord community Had tried escaping quotes for PowerShell passing in CodeQL build, but was issue with CodeQL itself, see github/codeql-action#851 (comment) Related PowerShell Info: https://stackoverflow.com/questions/6714165/powershell-stripping-double-quotes-from-command-line-arguments https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_parsing?view=powershell-7.3#passing-arguments-that-contain-quote-characters
Tested locally on single-component WASM head, noticed no difference in behavior
michael-hawker
force-pushed
the
fix-quotes
branch
from
2f3aa1d
to
fc48021
Compare
Arlodotexe
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up CodeQL here: CommunityToolkit/Windows#190
Was investigating issues which ended up being because of CodeQL itself stripping parameter quotes (have discussion going with them).
Anyway, based on conversations in the PowerShell Discord (much thanks to
jboreanfrom there), cleaned up our calls to the shell in our Generate Solutions script. Figured would be good to still keep them even though they weren't the root cause. Seems like they'll be easier to read and maintain anyway.Using this branch to also fix CodeQL related issues. The web.config needed to be updated, I filed an Uno issue about the default value: unoplatform/uno#13414
Going to leave as draft for a sec to see if any more hits on the next scan on the cleaned-up CodeQL PR.