Fix Sample App Search #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't lowering the query so wasn't doing case-insensitive as desired Also add searching descriptions of samples
Arlodotexe
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over from my Store SDK PR as that's breaking the build, will need to figure that out after shipping. For now I can merge that in locally when building the final app.
In the meantime though, seems like we should at least check-in the quick change I did orthogonal on that one to fix the Sample App Search.
Quick two-liner to just ensure the query is made lower case so we do a case-insensitive search.
And we'll search descriptions now, so it gives us a bit better 'fuzzy' search for people looking for different more general things.
Oh, and made 8.0.0 the default for sample app versions.