Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert WinAppSdkTargetFramework version from 22621 to 19041. #220

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Arlodotexe
Copy link
Member

Prerequisite PR CommunityToolkit/Windows#540

Since Win2d 1.1.1 was the reason we originally bumped our Windows App SDK TFM to 22621 (see #161, microsoft/Win2D#943) and 1.3.0 has reverted to 19041, we can reduce our TFM back down to 19041.

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker
Copy link
Member

We should still have something like Morten suggested for if folks try and use a lower TFM than 19041 too, eh? (And then we can decide if we hot-fix 8.1 to use that for 22621, eh?)

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 25, 2024

Think there's a couple of more places we need to modify, no? https://github.com/search?q=repo%3ACommunityToolkit%2FTooling-Windows-Submodule%2022621&type=code

No, at least not for this PR. There are four instances of use in the search results link provided:

The last two are slated for removal entirely as per @Sergio0694's advice in #217 (comment) and #217 (comment), which will be done in this PR.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 25, 2024

We should still have something like Morten suggested for if folks try and use a lower TFM than 19041 too, eh? (And then we can decide if we hot-fix 8.1 to use that for 22621, eh?)

Yes, though I'm still working through many of the nuances to make sure we can apply it to all toolkit components automatically, instead of manually doing it one-by-one. Can discuss in more detail in a dedicated ticket, or over on Discord in the CommunityToolkit channel.

Here, we're just reducing the TFMs back down, whether we decide to hotfix or not.

@Arlodotexe Arlodotexe self-assigned this Oct 25, 2024
@Arlodotexe Arlodotexe merged commit a9d01ea into main Oct 25, 2024
8 checks passed
@Arlodotexe Arlodotexe deleted the multitarget/wasdk/tfm branch October 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants