Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate action threshold #59

Closed
bradduthie opened this issue Apr 1, 2020 · 1 comment
Closed

Incorporate action threshold #59

bradduthie opened this issue Apr 1, 2020 · 1 comment
Assignees
@bradduthie
Labels
To do Things to do to improve GMSE

Comments

@bradduthie
Copy link
Member

The code from @AdrianBach needs to be incorporated into the master branch of GMSE. Doing this will mainly consist of resolving a merge conflict and a bit of refactoring, and I plan to do this early on in developing what I hope to be a new version of GMSE by the end of APR 2020.
@bradduthie bradduthie self-assigned this Apr 1, 2020
@bradduthie bradduthie added the To do Things to do to improve GMSE label Apr 1, 2020
bradduthie added a commit that referenced this issue Apr 1, 2020
@bradduthie
Update on how the new version will be developed for GMSE, which will …
9c05394 
…address Issues #53 #59 and #56 and incorporate code from @AdrianBach into the master branch. I will also atempt a major new feature allowing landscape consumption to affect demographics, with conversations from @jejoenje @nbunne and others. Other updates are welcome -- just make a new branch that can be merged later.
bradduthie added a commit that referenced this issue Apr 13, 2020
@bradduthie
Update the version number. Next will merge the action_threshold_branc…
9657de8 
…h with code from @AdrianBach to address Issue #59
bradduthie added a commit that referenced this issue Apr 13, 2020
@bradduthie
Rework the gmse_apply code so that the new inputs from the work of @A…
d48a4f9 
…drianBach Issue #59  and options for variation in user budgets can be put into GMSE apply. The changes now get into the paras vector appropriately, and do not cause any crash, but further testing is needed to make sure that gmse_apply is using the information correctly, and testthat functions need to be rewritten.
bradduthie added a commit that referenced this issue Apr 13, 2020
@bradduthie
Update notebook with new Issues #53 and #59 resolved in the rev branc…
cf25727 
…h, incorporating code from @AdrianBach and crane code from Lovisa's project
@bradduthie
Copy link
Member Author

This is complete as of v0.5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradduthie bradduthie

Labels
To do Things to do to improve GMSE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradduthie