remove one line if statements

ConductionNL · Nov 10, 2023 · b84ab13 · b84ab13
1 parent 8e9b129
commit b84ab13
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/api/src/Repository/ObjectEntityRepository.php b/api/src/Repository/ObjectEntityRepository.php
@@ -66,7 +66,10 @@ public function getFilterParameters(Entity $Entity, string $prefix = '', int $le
                 $filters[] = $prefix.$attribute->getName();
             } elseif ($attribute->getObject() && $level < 3 && !str_contains($prefix, $attribute->getName().'.')) {
                 $attribute->getSearchable() && $filters[] = $prefix.$attribute->getName();
-                $embeddedString = $embedded && $level > 1 ? 'embedded.' : '';
+                $embeddedString = '';
+                if ($embedded && $level > 1) {
+                    $embeddedString = 'embedded.';
+                }
                 $filters = array_merge($filters, $this->getFilterParameters($attribute->getObject(), $prefix.$embeddedString.$attribute->getName().'.', $level + 1, $embedded));
             }
         }
@@ -86,15 +89,21 @@ public function getFilterParameters(Entity $Entity, string $prefix = '', int $le
      */
     public function getOrderParameters(Entity $Entity, string $prefix = '', int $level = 1, bool $embedded = false): array
     {
-        $prefix = $embedded && $level === 2 ? "embedded.$prefix" : $prefix;
+        $prefix = $prefix;
+        if ($embedded && $level === 2) {
+            $prefix = "embedded.$prefix";
+        }
         // defaults
         $sortable = [$prefix.'_dateCreated', $prefix.'_dateModified'];
 
         foreach ($Entity->getAttributes() as $attribute) {
             if (in_array($attribute->getType(), ['string', 'date', 'datetime', 'integer', 'float', 'number']) && $attribute->getSortable()) {
                 $sortable[] = $prefix.$attribute->getName();
             } elseif ($attribute->getObject() && $level < 3 && !str_contains($prefix, $attribute->getName().'.')) {
-                $embeddedString = $embedded && $level > 1 ? 'embedded.' : '';
+                $embeddedString = '';
+                if ($embedded && $level > 1) {
+                    $embeddedString = 'embedded.';
+                }
                 $sortable = array_merge($sortable, $this->getOrderParameters($attribute->getObject(), $prefix.$embeddedString.$attribute->getName().'.', $level + 1));
             }
         }