From 7bf8b07546611f28c0d814345338837d07a0445d Mon Sep 17 00:00:00 2001
From: Remko <remkohuisman@hotmail.nl>
Date: Tue, 10 Oct 2023 14:39:12 +0200
Subject: [PATCH] added Clickables, Forms and Document improvements

---
 pwa/src/templates/jumbotronTemplate/JumbotronTemplate.tsx  | 7 ++++++-
 .../templates/templateParts/filters/FiltersTemplate.tsx    | 3 +++
 pwa/src/templates/templateParts/footer/FooterTemplate.tsx  | 1 +
 pwa/src/translations/en.ts                                 | 3 +++
 pwa/src/translations/nl.ts                                 | 2 ++
 5 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/pwa/src/templates/jumbotronTemplate/JumbotronTemplate.tsx b/pwa/src/templates/jumbotronTemplate/JumbotronTemplate.tsx
index 35aed429..e18490bb 100644
--- a/pwa/src/templates/jumbotronTemplate/JumbotronTemplate.tsx
+++ b/pwa/src/templates/jumbotronTemplate/JumbotronTemplate.tsx
@@ -8,7 +8,12 @@ export const JumbotronTemplate: React.FC = () => {
   const { t } = useTranslation();
 
   return (
-    <div style={{ backgroundImage: `url(${process.env.GATSBY_JUMBOTRON_IMAGE_URL})` }} className={styles.wrapper}>
+    <div
+      aria-label={t("Jumbotron")}
+      role="contentinfo"
+      style={{ backgroundImage: `url(${process.env.GATSBY_JUMBOTRON_IMAGE_URL})` }}
+      className={styles.wrapper}
+    >
       <Page>
         <PageContent>
           <div>
diff --git a/pwa/src/templates/templateParts/filters/FiltersTemplate.tsx b/pwa/src/templates/templateParts/filters/FiltersTemplate.tsx
index e293e023..8537d6e5 100644
--- a/pwa/src/templates/templateParts/filters/FiltersTemplate.tsx
+++ b/pwa/src/templates/templateParts/filters/FiltersTemplate.tsx
@@ -55,6 +55,7 @@ export const FiltersTemplate: React.FC<FiltersTemplateProps> = ({ isLoading }) =
           name="title"
           placeholder={`${t("Search")}..`}
           defaultValue={filters._search}
+          aria-label={t("Search")}
           {...{ register, errors }}
         />
         <SelectSingle
@@ -63,6 +64,7 @@ export const FiltersTemplate: React.FC<FiltersTemplateProps> = ({ isLoading }) =
           placeholder={t("Year")}
           isClearable
           {...{ register, errors, control }}
+          aria-label={t("Select year")}
         />
         <SelectSingle
           options={TEMP_PUBLICATION_TYPES}
@@ -71,6 +73,7 @@ export const FiltersTemplate: React.FC<FiltersTemplateProps> = ({ isLoading }) =
           defaultValue={TEMP_PUBLICATION_TYPES.find((option) => option.value === filters.Categorie)}
           isClearable
           {...{ register, errors, control }}
+          aria-label={t("Select category")}
         />
 
         <Button type="submit" className={styles.button} disabled={isLoading}>
diff --git a/pwa/src/templates/templateParts/footer/FooterTemplate.tsx b/pwa/src/templates/templateParts/footer/FooterTemplate.tsx
index be32926f..d8b95a45 100644
--- a/pwa/src/templates/templateParts/footer/FooterTemplate.tsx
+++ b/pwa/src/templates/templateParts/footer/FooterTemplate.tsx
@@ -72,6 +72,7 @@ const DynamicSection: React.FC<{ content: TDynamicContentItem }> = ({ content })
               onClick={() => navigate(item.link ?? "")}
               tabIndex={0}
               aria-label={`${t(item.label)}, ${t(item.value)}`}
+              role="button"
             >
               {item.value}
             </Link>
diff --git a/pwa/src/translations/en.ts b/pwa/src/translations/en.ts
index ec630d85..896ab24c 100644
--- a/pwa/src/translations/en.ts
+++ b/pwa/src/translations/en.ts
@@ -41,4 +41,7 @@ export const en = {
   "Skip to footer content": "Skip to footer content",
   "Phone number": "Phone number",
   "Email address": "Email address",
+  "Select year": "Select year",
+  "Select category": "Select category",
+  
 };
diff --git a/pwa/src/translations/nl.ts b/pwa/src/translations/nl.ts
index 3180f27e..e411bccd 100644
--- a/pwa/src/translations/nl.ts
+++ b/pwa/src/translations/nl.ts
@@ -41,4 +41,6 @@ export const nl = {
   "Skip to footer content": "Ga naar de voettekst",
   "Phone number": "Telefoonnummer",
   "Email address": "E-mailadres",
+  "Select year": "Selecteer jaar",
+  "Select category": "Selecteer categorie",
 };