Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(CLI): Improve error message when config file is not correct #2128

Closed
raulb opened this issue Feb 5, 2025 · 2 comments · Fixed by ConduitIO/ecdysis#15
Closed

Feature(CLI): Improve error message when config file is not correct #2128

raulb opened this issue Feb 5, 2025 · 2 comments · Fixed by ConduitIO/ecdysis#15
Assignees
@raulb
Labels
feature New feature or request

Comments

@raulb
Copy link
Member

raulb commented Feb 5, 2025

Feature description

Reported by @lyuboxa

I found this somewhat confusing

$ conduit run --config.path foo
Error: error parsing config: fatal error config file: Unsupported Config Type ""

2 things come to mind:
conduit run expects a file so --config.file may be a better verb?
I passed non-existent file or folder, this can be detected
@raulb raulb added feature New feature or request triage Needs to be triaged labels Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Triage in Conduit Main Feb 5, 2025
@raulb raulb moved this from Triage to In Progress in Conduit Main Feb 5, 2025
@raulb raulb removed the triage Needs to be triaged label Feb 5, 2025
@raulb raulb self-assigned this Feb 5, 2025
@raulb
Copy link
Member Author

raulb commented Feb 5, 2025 •
edited
Loading

Related spf13/viper#818. Fix will need to take place in https://github.com/ConduitIO/ecdysis

raulb added a commit to ConduitIO/ecdysis that referenced this issue Feb 5, 2025
@raulb
set config type
195b39c 
fixes ConduitIO/conduit#2128
@raulb raulb mentioned this issue Feb 5, 2025
Merged
@raulb raulb moved this from In Progress to Ready for review in Conduit Main Feb 5, 2025
@raulb
Copy link
Member Author

raulb commented Feb 5, 2025

PR ConduitIO/ecdysis#15

@github-project-automation github-project-automation bot moved this from Ready for review to Done in Conduit Main Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulb raulb

Labels
feature New feature or request
Projects
Conduit Main
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unsupported type error ConduitIO/ecdysis
1 participant
@raulb