fix(router): route Swagger doc missing non-global security headers (#818

) * fix(router): route swagger doc missing non-global security headers * fix(router): invalid authMiddleware condition handling
ConduitPlatform · Nov 24, 2023 · 23a425c · 23a425c
1 parent 2e0a4ae
commit 23a425c
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/modules/router/src/hermes/swaggerMetadata.ts b/modules/router/src/hermes/swaggerMetadata.ts
@@ -6,7 +6,7 @@ export const getSwaggerMetadata: () => SwaggerRouterMetadata = () => ({
   urlPrefix: '',
   securitySchemes: {
     clientId: {
-      name: 'clientid',
+      name: 'clientId',
       type: 'apiKey',
       in: 'header',
       description: 'A security client id, retrievable through [POST] /security/client',
@@ -37,15 +37,20 @@ export const getSwaggerMetadata: () => SwaggerRouterMetadata = () => ({
   setExtraRouteHeaders(route: ConduitRoute, swaggerRouteDoc: Indexable): void {
     // https://swagger.io/docs/specification/authentication/#multiple
     if (route.input.middlewares?.includes('authMiddleware')) {
+      if (swaggerRouteDoc.security.length === 0) {
+        swaggerRouteDoc.security.push({});
+      }
       // Logical AND
       swaggerRouteDoc.security = swaggerRouteDoc.security.map(
         (originalSecEntry: { [field: string]: string }) => ({
           ...originalSecEntry,
           userToken: [],
         }),
       );
-    }
-    if (route.input.middlewares?.includes('authMiddleware?')) {
+    } else if (route.input.middlewares?.includes('authMiddleware?')) {
+      if (swaggerRouteDoc.security.length === 0) {
+        swaggerRouteDoc.security.push({});
+      }
       // Logical OR
       swaggerRouteDoc.security.forEach(
         (originalSecEntry: { [field: string]: string }) => {