Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Increase our unit test coverage #103

Open
knelasevero opened this issue Oct 7, 2020 · 1 comment
Open

Increase our unit test coverage #103

knelasevero opened this issue Oct 7, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed testing

Comments

@knelasevero
Copy link
Contributor

knelasevero commented Oct 7, 2020

I am opening this issue as a general issue to attract hacktoberfestians, but we can later open sub-issues to be more specific on what types of testes and where we want them.

Generally we want tests for our main controller (responsible for our reconciliation loop) or/and our backends (responsible for implementing our interface to external secrets solutions support).

Example:

This is the Google Secrets Manager Backend implementation: pkg/gsm/backend.go

This is where its tests are implemented: pkg/gsm/backend_test.go

Our controller logic: controllers/secrets/externalsecret_controller.go

Its tests: controllers/secrets/externalsecret_controller_test.go

I will try to add a checklist here later. But generally if you implement a meaningful test in these places they will be welcomed.

You can also checkout codecov to see where we have less coverage to bump it up a bit.

@knelasevero knelasevero added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest testing labels Oct 7, 2020
@allanmoso
Copy link
Contributor

I can probably help with this. I see the following places that could be improved based on codecov:

  • gsm/backend.go
  • controllers/secrets/externalsecret_controller.go
  • onepassword/op.go

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed testing
Projects
None yet
Development

No branches or pull requests

4 participants