Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tflint errors #176

Open
melihc1 opened this issue Aug 3, 2022 · 2 comments
Open

Fix tflint errors #176

melihc1 opened this issue Aug 3, 2022 · 2 comments
Labels
CI CI related topics - actions, tooling, scripts, etc. good first issue Good for newcomers

Comments

@melihc1
Copy link
Collaborator

melihc1 commented Aug 3, 2022

Check for latest runs and fix deprecation related errors

Example error: https://github.com/ContainerSolutions/terraform-examples/runs/7654637304?check_suite_focus=true#step:4:1494

Warning: Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on main.tf line 23:
  23:     "${file("values.yaml")}"

Reference: https://github.com/terraform-linters/tflint/blob/v0.39.1/docs/rules/terraform_deprecated_interpolation.md
@melihc1 melihc1 added the CI CI related topics - actions, tooling, scripts, etc. label Aug 18, 2022
@ttarczynski ttarczynski added the good first issue Good for newcomers label Sep 15, 2022
@melihc1
Copy link
Collaborator Author

melihc1 commented Sep 20, 2022

Latest version of tflint (v0.40) has many more errors:

https://github.com/ContainerSolutions/terraform-examples/actions/runs/3091438826/jobs/5001511068

Logs uploaded as txt:
logs.txt

@kolja-lucht
Copy link

Hey @ttarczynski and @melihc1,
I'd be happy to pick up some of the tflint errors and fix them. Do you have a preferred way of tackling them? Like fix errors of the same kind in one PR or rather go based on in which example they appear or even a different way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related topics - actions, tooling, scripts, etc. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants